Return-Path: X-Original-To: apmail-curator-dev-archive@minotaur.apache.org Delivered-To: apmail-curator-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2320110E8B for ; Tue, 4 Jun 2013 17:59:48 +0000 (UTC) Received: (qmail 27612 invoked by uid 500); 4 Jun 2013 17:59:48 -0000 Delivered-To: apmail-curator-dev-archive@curator.apache.org Received: (qmail 27588 invoked by uid 500); 4 Jun 2013 17:59:48 -0000 Mailing-List: contact dev-help@curator.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.incubator.apache.org Delivered-To: mailing list dev@curator.incubator.apache.org Received: (qmail 27580 invoked by uid 99); 4 Jun 2013 17:59:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2013 17:59:47 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 04 Jun 2013 17:59:42 +0000 Received: (qmail 26838 invoked by uid 99); 4 Jun 2013 17:59:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Jun 2013 17:59:20 +0000 Date: Tue, 4 Jun 2013 17:59:20 +0000 (UTC) From: "Jordan Zimmerman (JIRA)" To: dev@curator.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CURATOR-14) Memory leak in Curator watches MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/CURATOR-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13674620#comment-13674620 ] Jordan Zimmerman commented on CURATOR-14: ----------------------------------------- >Regarding the WatcherKey, do u see it as a way of wrapping Watcher/CuratorWatcher objects or you think that the recipes should directly use anonymous inner implementations of the WatcherKey? Yes. The idea is to have a semi-opaque type that isn't accepted in any Curator/ZooKeeper API. This way, the user can't make a mistake. What do you think? > Memory leak in Curator watches > ------------------------------ > > Key: CURATOR-14 > URL: https://issues.apache.org/jira/browse/CURATOR-14 > Project: Apache Curator > Issue Type: New Feature > Components: Recipes > Affects Versions: 2.0.0-incubating > Reporter: Brandon Beck > Priority: Minor > Attachments: CURATOR-14-draft-2.patch, CURATOR-14-draft-3.patch, CURATOR-14.patch, MemoryTest.java > > > The JVM runs out of memory if you repetitively create a PathChildrenCache, start it then immediately stop it. It appears that the memory is taken up by a watch that isn't ever cleaned up. Curator attempts to do some pooling of watches, but doesn't seem to use the path in the pooling. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira