Mailing-List: contact dev-help@curator.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@curator.incubator.apache.org
Date: Thu, 2 May 2013 11:24:16 +0000 (UTC)
From: "Ioannis Canellos (JIRA)" <jira@apache.org>
To: dev@curator.incubator.apache.org
Message-ID: <JIRA.12641474.1365461073498.259896.1367493856099@arcas>
In-Reply-To: <JIRA.12641474.1365461073498@arcas>
References: <JIRA.12641474.1365461073498@arcas>
Subject: [jira] [Commented] (CURATOR-14) Memory leak in Curator watches
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CURATOR-14?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13647447#comment-13647447 ] 

Ioannis Canellos commented on CURATOR-14:
-----------------------------------------

I tried the suggested approach about caching watchers and it seems to work. The only problem is providing a working equals() and hashCode() for the Watchers implemented as anonymous inner classes. So I think that something like a CacheableWatcher that could provide an impl of these two based on a key property could reduce the boilerplate.

If no one is already working on it I could provide a patch.
                
> Memory leak in Curator watches
> ------------------------------
>
>                 Key: CURATOR-14
>                 URL: https://issues.apache.org/jira/browse/CURATOR-14
>             Project: Apache Curator
>          Issue Type: New Feature
>          Components: Recipes
>    Affects Versions: 2.0.0
>            Reporter: Brandon Beck
>            Assignee: Jordan Zimmerman
>            Priority: Minor
>         Attachments: MemoryTest.java
>
>
> The JVM runs out of memory if you repetitively create a PathChildrenCache, start it then immediately stop it.  It appears that the memory is taken up by a watch that isn't ever cleaned up.  Curator attempts to do some pooling of watches, but doesn't seem to use the path in the pooling.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira