Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 744B7200B73 for ; Mon, 15 Aug 2016 01:34:49 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 72EB6160AB4; Sun, 14 Aug 2016 23:34:49 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B807D160AA9 for ; Mon, 15 Aug 2016 01:34:48 +0200 (CEST) Received: (qmail 56550 invoked by uid 500); 14 Aug 2016 23:34:47 -0000 Mailing-List: contact commits-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list commits@curator.apache.org Received: (qmail 56541 invoked by uid 99); 14 Aug 2016 23:34:47 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 14 Aug 2016 23:34:47 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id C42F4E01E2; Sun, 14 Aug 2016 23:34:47 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: cammckenzie@apache.org To: commits@curator.apache.org Message-Id: <51a71cf4f4234e9b85c3427e9cd5577c@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: curator git commit: CURATOR-341: Don't retry create operation after setData Date: Sun, 14 Aug 2016 23:34:47 +0000 (UTC) archived-at: Sun, 14 Aug 2016 23:34:49 -0000 Repository: curator Updated Branches: refs/heads/CURATOR-341 [created] 9612c5fbf CURATOR-341: Don't retry create operation after setData Resulted in infinite amount of retries Project: http://git-wip-us.apache.org/repos/asf/curator/repo Commit: http://git-wip-us.apache.org/repos/asf/curator/commit/9612c5fb Tree: http://git-wip-us.apache.org/repos/asf/curator/tree/9612c5fb Diff: http://git-wip-us.apache.org/repos/asf/curator/diff/9612c5fb Branch: refs/heads/CURATOR-341 Commit: 9612c5fbf6d1bcac591f0d627c05abc85cd975c4 Parents: 7e8a76e Author: Henrik Nordvik Authored: Thu Aug 11 12:17:02 2016 +0200 Committer: Henrik Nordvik Committed: Thu Aug 11 12:59:05 2016 +0200 ---------------------------------------------------------------------- .../org/apache/curator/framework/imps/CreateBuilderImpl.java | 1 - .../java/org/apache/curator/framework/imps/TestFramework.java | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/curator/blob/9612c5fb/curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java ---------------------------------------------------------------------- diff --git a/curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java b/curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java index 8096802..34009b1 100644 --- a/curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java +++ b/curator-framework/src/main/java/org/apache/curator/framework/imps/CreateBuilderImpl.java @@ -749,7 +749,6 @@ class CreateBuilderImpl implements CreateBuilder, BackgroundOperation(operation, null, null, null, null, null)); http://git-wip-us.apache.org/repos/asf/curator/blob/9612c5fb/curator-framework/src/test/java/org/apache/curator/framework/imps/TestFramework.java ---------------------------------------------------------------------- diff --git a/curator-framework/src/test/java/org/apache/curator/framework/imps/TestFramework.java b/curator-framework/src/test/java/org/apache/curator/framework/imps/TestFramework.java index 7234088..44f9486 100644 --- a/curator-framework/src/test/java/org/apache/curator/framework/imps/TestFramework.java +++ b/curator-framework/src/test/java/org/apache/curator/framework/imps/TestFramework.java @@ -191,6 +191,10 @@ public class TestFramework extends BaseClassForTests Assert.assertEquals(event.getType(), CuratorEventType.CREATE); Assert.assertEquals(event.getPath(), "/a/b/c"); Assert.assertEquals(event.getName(), "/a/b/c"); + + // callback should only be called once + CuratorEvent unexpectedEvent = queue.poll(new Timing().milliseconds(), TimeUnit.MILLISECONDS); + Assert.assertNull(unexpectedEvent); } finally {