Return-Path: X-Original-To: apmail-curator-commits-archive@minotaur.apache.org Delivered-To: apmail-curator-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 723B118DEF for ; Tue, 1 Sep 2015 13:27:54 +0000 (UTC) Received: (qmail 31800 invoked by uid 500); 1 Sep 2015 13:27:54 -0000 Delivered-To: apmail-curator-commits-archive@curator.apache.org Received: (qmail 31724 invoked by uid 500); 1 Sep 2015 13:27:54 -0000 Mailing-List: contact commits-help@curator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.apache.org Delivered-To: mailing list commits@curator.apache.org Received: (qmail 30815 invoked by uid 99); 1 Sep 2015 13:27:53 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Sep 2015 13:27:53 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id D5331DFF8C; Tue, 1 Sep 2015 13:27:53 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: randgalt@apache.org To: commits@curator.apache.org Date: Tue, 01 Sep 2015 13:28:16 -0000 Message-Id: In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [24/45] curator git commit: doc doc Project: http://git-wip-us.apache.org/repos/asf/curator/repo Commit: http://git-wip-us.apache.org/repos/asf/curator/commit/9c7cf5d8 Tree: http://git-wip-us.apache.org/repos/asf/curator/tree/9c7cf5d8 Diff: http://git-wip-us.apache.org/repos/asf/curator/diff/9c7cf5d8 Branch: refs/heads/CURATOR-248 Commit: 9c7cf5d8ba495bccdea2bcb6b377e95f5f99d521 Parents: 64d966c Author: randgalt Authored: Sun Aug 23 11:02:19 2015 -0500 Committer: randgalt Committed: Sun Aug 23 11:02:19 2015 -0500 ---------------------------------------------------------------------- .../apache/curator/framework/CuratorFrameworkFactory.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/curator/blob/9c7cf5d8/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java ---------------------------------------------------------------------- diff --git a/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java b/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java index 01a8666..c59d78f 100644 --- a/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java +++ b/curator-framework/src/main/java/org/apache/curator/framework/CuratorFrameworkFactory.java @@ -368,11 +368,10 @@ public class CuratorFrameworkFactory * by the CuratorFramework instance. There should be no noticeable differences. * *
  • - * Prior to 3.0.0, an elapsed connection timeout would be presented to the retry policy, possibly - * causing retries. Now, elapsed connection timeouts are only retried if there is an another server - * in the connection string. i.e. a new instance will be retried should the retry policy allow a retry. - * If no other servers remain, a {@link KeeperException.ConnectionLossException} is thrown immediately - * without notifying the retry policy. + * Prior to 3.0.0, each iteration of the retry policy would allow the connection timeout to elapse + * if the connection hadn't yet succeeded. This meant that the true connection timeout was the configured + * value times the maximum retries in the retry policy. This longstanding issue has been address. + * Now, the connection timeout can elapse only once for a single API call. *
    • *
  • * MOST IMPORTANTLY! Prior to 3.0.0, {@link ConnectionState#LOST} did not imply