Return-Path: X-Original-To: apmail-curator-commits-archive@minotaur.apache.org Delivered-To: apmail-curator-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A44DA105C0 for ; Wed, 25 Sep 2013 03:32:06 +0000 (UTC) Received: (qmail 55829 invoked by uid 500); 25 Sep 2013 03:32:06 -0000 Delivered-To: apmail-curator-commits-archive@curator.apache.org Received: (qmail 55794 invoked by uid 500); 25 Sep 2013 03:32:03 -0000 Mailing-List: contact commits-help@curator.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@curator.incubator.apache.org Delivered-To: mailing list commits@curator.incubator.apache.org Received: (qmail 55786 invoked by uid 99); 25 Sep 2013 03:32:01 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Sep 2013 03:32:01 +0000 X-ASF-Spam-Status: No, hits=-2002.3 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 25 Sep 2013 03:31:59 +0000 Received: (qmail 55718 invoked by uid 99); 25 Sep 2013 03:31:37 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Sep 2013 03:31:37 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id E20C090954A; Wed, 25 Sep 2013 03:31:36 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: randgalt@apache.org To: commits@curator.incubator.apache.org Message-Id: <8643b845f56d4c418b941e8db347649d@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: git commit: Use isTraceEnabled to prevent unnecessary string concat Date: Wed, 25 Sep 2013 03:31:36 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Updated Branches: refs/heads/CURATOR-9 [created] 852e3fd3f Use isTraceEnabled to prevent unnecessary string concat Project: http://git-wip-us.apache.org/repos/asf/incubator-curator/repo Commit: http://git-wip-us.apache.org/repos/asf/incubator-curator/commit/852e3fd3 Tree: http://git-wip-us.apache.org/repos/asf/incubator-curator/tree/852e3fd3 Diff: http://git-wip-us.apache.org/repos/asf/incubator-curator/diff/852e3fd3 Branch: refs/heads/CURATOR-9 Commit: 852e3fd3f9e7a15a4bebbf97014b032f9c307ed8 Parents: bb663fd Author: randgalt Authored: Tue Sep 24 20:32:48 2013 -0700 Committer: randgalt Committed: Tue Sep 24 20:32:48 2013 -0700 ---------------------------------------------------------------------- .../org/apache/curator/utils/DefaultTracerDriver.java | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/incubator-curator/blob/852e3fd3/curator-client/src/main/java/org/apache/curator/utils/DefaultTracerDriver.java ---------------------------------------------------------------------- diff --git a/curator-client/src/main/java/org/apache/curator/utils/DefaultTracerDriver.java b/curator-client/src/main/java/org/apache/curator/utils/DefaultTracerDriver.java index 632a479..e6bdabb 100644 --- a/curator-client/src/main/java/org/apache/curator/utils/DefaultTracerDriver.java +++ b/curator-client/src/main/java/org/apache/curator/utils/DefaultTracerDriver.java @@ -33,12 +33,18 @@ public class DefaultTracerDriver implements TracerDriver @Override public void addTrace(String name, long time, TimeUnit unit) { - log.trace("Trace: " + TimeUnit.MILLISECONDS.convert(time, unit) + " ms"); + if ( log.isTraceEnabled() ) + { + log.trace("Trace: " + TimeUnit.MILLISECONDS.convert(time, unit) + " ms"); + } } @Override public void addCount(String name, int increment) { - log.trace("Counter " + name + ": " + increment); + if ( log.isTraceEnabled() ) + { + log.trace("Counter " + name + ": " + increment); + } } }