curator-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From randg...@apache.org
Subject [5/9] git commit: Removed refreshPaddingMs. Since switching to PathChildrenCache this no longer applies
Date Sun, 07 Jul 2013 17:27:00 GMT
Removed refreshPaddingMs. Since switching to PathChildrenCache this no longer applies


Project: http://git-wip-us.apache.org/repos/asf/incubator-curator/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-curator/commit/acf9c893
Tree: http://git-wip-us.apache.org/repos/asf/incubator-curator/tree/acf9c893
Diff: http://git-wip-us.apache.org/repos/asf/incubator-curator/diff/acf9c893

Branch: refs/heads/master
Commit: acf9c8930755d119f1ceb089a8529eb7b9fa9da9
Parents: 05c6c4f
Author: randgalt <randgalt@apache.org>
Authored: Tue Jun 25 08:10:47 2013 -0500
Committer: randgalt <randgalt@apache.org>
Committed: Tue Jun 25 08:10:47 2013 -0500

----------------------------------------------------------------------
 .../curator/x/discovery/ServiceProviderBuilder.java | 10 ----------
 .../details/ServiceProviderBuilderImpl.java         | 16 ----------------
 2 files changed, 26 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-curator/blob/acf9c893/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceProviderBuilder.java
----------------------------------------------------------------------
diff --git a/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceProviderBuilder.java
b/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceProviderBuilder.java
index 59596a2..e6eaa39 100644
--- a/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceProviderBuilder.java
+++ b/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/ServiceProviderBuilder.java
@@ -55,16 +55,6 @@ public interface ServiceProviderBuilder<T>
      */
     public ServiceProviderBuilder<T> threadFactory(ThreadFactory threadFactory);
 
-    /**
-     * optional - To avoid herding in noisy scenarios, the cache should be padded to only
update 1 per period.
-     * The refresh padding is that period in milliseconds. Set to 0 to turn off padding.
The default
-     * is 1 second.
-     *
-     * @param refreshPaddingMs padding in milliseconds
-     * @return this
-     */
-    public ServiceProviderBuilder<T> refreshPaddingMs(int refreshPaddingMs);
-
     public ServiceProviderBuilder<T> downInstanceArguments(long timeout, TimeUnit unit,
int threshold);
 
     public ServiceProviderBuilder<T> additionalFilter(InstanceFilter<T> filter);

http://git-wip-us.apache.org/repos/asf/incubator-curator/blob/acf9c893/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceProviderBuilderImpl.java
----------------------------------------------------------------------
diff --git a/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceProviderBuilderImpl.java
b/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceProviderBuilderImpl.java
index 200ac06..7c811b5 100644
--- a/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceProviderBuilderImpl.java
+++ b/curator-x-discovery/src/main/java/org/apache/curator/x/discovery/details/ServiceProviderBuilderImpl.java
@@ -38,7 +38,6 @@ class ServiceProviderBuilderImpl<T> implements ServiceProviderBuilder<T>
     private String serviceName;
     private ProviderStrategy<T> providerStrategy;
     private ThreadFactory threadFactory;
-    private int refreshPaddingMs;
     private DownInstanceManager<T> downInstanceManager = new DownInstanceManager<T>();
     private List<InstanceFilter<T>> filters = Lists.newArrayList();
 
@@ -93,21 +92,6 @@ class ServiceProviderBuilderImpl<T> implements ServiceProviderBuilder<T>
         return this;
     }
 
-    /**
-     * optional To avoid herding in noisy scenarios, the cache should be padded to only update
1 per period.
-     * The refresh padding is that period in milliseconds. Set to 0 to turn off padding.
The default
-     * is 1 second.
-     *
-     * @param refreshPaddingMs padding in milliseconds
-     * @return this
-     */
-    @Override
-    public ServiceProviderBuilder<T> refreshPaddingMs(int refreshPaddingMs)
-    {
-        this.refreshPaddingMs = refreshPaddingMs;
-        return this;
-    }
-
     @Override
     public ServiceProviderBuilder<T> downInstanceArguments(long timeout, TimeUnit unit,
int threshold)
     {


Mime
View raw message