ctakes-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Zbarcea (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CTAKES-472) upgrade Spring dependency from 3.1.2 to 4.x
Date Sun, 19 Nov 2017 01:51:00 GMT

    [ https://issues.apache.org/jira/browse/CTAKES-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258288#comment-16258288
] 

Alex Zbarcea commented on CTAKES-472:
-------------------------------------

I will have my reviews in this note ... Please consider my reviews as simple observations.


For others who want to review the commit, this is a {{git patch}}:
{code}
git apply ctakes-spring-upgrade.patch
{code}
----
* *dependency defined in main {{pom.xml}}. No reason to redefine property in modules*. Same
for {{depdencyManagement}}.
{code}
<spring.version>4.3.12.RELEASE</spring.version>
{code}

----
* *path to local {{M2_HOME}} without using environment variable*. Not a problem with the current
patch, but *critical* as it is enforcing (undocumented) development setup. Makes the whole
build completely unpredictable. {{TODO: Should be treated as a different issue.}}
{code}
+        <pathelement location="../../../../.m2/repository/org/springframework/spring-core/4.3.12.RELEASE/spring-core-4.3.12.RELEASE.jar"/>
+        <pathelement location="../../../../.m2/repository/org/springframework/spring-asm/4.3.12.RELEASE/spring-asm-4.3.12.RELEASE.jar"/>
{code}


> upgrade Spring dependency from 3.1.2 to 4.x
> -------------------------------------------
>
>                 Key: CTAKES-472
>                 URL: https://issues.apache.org/jira/browse/CTAKES-472
>             Project: cTAKES
>          Issue Type: New Feature
>    Affects Versions: 4.0.0
>            Reporter: Alex Zbarcea
>            Assignee: Alex Zbarcea
>         Attachments: ctakes-spring-upgrade.patch
>
>
> {quote}
> From	Gandhi Rajan Natarajan <Gandhi.Natara...@arisglobal.com>
> Subject	cTAKES as REST service
> Date	Wed, 25 Oct 2017 13:20:14 GMT
> Hi All,
> We have extended the cTAKES web application available under https://github.com/healthnlp/examples/tree/master/ctakes-temporal-demo
> and added our custom annotator. We have tested the same and it works fine with CVD. But
we
> are facing problems while trying to expose this as rest service.
> cTAKES uses Spring 3.1.2 version internally which don't have out of the box support for
rest
> controller. Can we go ahead and update the spring version to 4x in cTAKES? Will it have
any
> impact in the cTAKES behavior? Also is there a better way to expose cTAKES as rest service
> apart from spring?
> Please advise.
> Regards,
> Gandhi
> {quote}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message