ctakes-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CTAKES-299) cannot configure ClearNLPSemanticRoleLabelerAE using XML descriptor
Date Tue, 14 Mar 2017 17:13:41 GMT

    [ https://issues.apache.org/jira/browse/CTAKES-299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924592#comment-15924592
] 

ASF subversion and git services commented on CTAKES-299:
--------------------------------------------------------

Commit 1786932 from james-masanz@apache.org in branch 'ctakes/trunk'
[ https://svn.apache.org/r1786932 ]

CTAKES-299 - ClearNLPSemanticRoleLabelerAE was not using the configuration parameters for
the model files

> cannot configure ClearNLPSemanticRoleLabelerAE using XML descriptor
> -------------------------------------------------------------------
>
>                 Key: CTAKES-299
>                 URL: https://issues.apache.org/jira/browse/CTAKES-299
>             Project: cTAKES
>          Issue Type: Bug
>          Components: ctakes-dependency-parser
>    Affects Versions: 3.1.1
>            Reporter: Mats Henrikson
>
> Due to a bug in {{org.apache.ctakes.dependency.parser.ae.ClearNLPSemanticRoleLabelerAE}}
it is not possible to configure it using an XML descriptor file.
> Unfortunately the 3 {{@ConfigurationParameter}} fields are configure but never read.
For example:
> {code:java}
>   @ConfigurationParameter(
> 		  name = PARAM_PARSER_MODEL_FILE_NAME,
> 		  ...)
>   private String parserModelFileName;
> {code}
> The field {{parserModelFileName}} is then never read again when trying to load the configured
file, instead the field {{this.srlPredUri}} is checked:
> {code:java}
>     	InputStream srlPred = (this.srlPredUri == null)
>                 ? FileLocator.getAsStream(DEFAULT_PRED_MODEL_FILE_NAME)
>                 : FileLocator.getAsStream(this.srlPredUri.getPath());
> {code}
> Please change the 3 {{@ConfigurationParameter}} annotations to be on the fields that
are then used to configure the class (similar to how {{ClearNLPDependencyParserAE}} is configured.)




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message