ctakes-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CTAKES-365) DocumentIDAnnotationUtil should not return null from getDocumentID
Date Wed, 08 Jul 2015 14:24:04 GMT

    [ https://issues.apache.org/jira/browse/CTAKES-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14618675#comment-14618675
] 

ASF subversion and git services commented on CTAKES-365:
--------------------------------------------------------

Commit 1689882 from [~seanfinan] in branch 'ctakes/trunk'
[ https://svn.apache.org/r1689882 ]

CTAKES-365 Added return constant "UnknownDocument" when the document id cannot be determined
-- replacing old null return
Main code change is in DocumentIDAnnotationUtil
All other files (mostly cas consumers) are updated to reflect the change

> DocumentIDAnnotationUtil should not return null from getDocumentID
> ------------------------------------------------------------------
>
>                 Key: CTAKES-365
>                 URL: https://issues.apache.org/jira/browse/CTAKES-365
>             Project: cTAKES
>          Issue Type: Task
>          Components: ctakes-core
>    Affects Versions: future enhancement
>            Reporter: Sean Finan
>            Assignee: Sean Finan
>            Priority: Minor
>             Fix For: future enhancement
>
>
> getDocumentID returns null if there are problems obtaining the document id from the cas.
 It should be changed to return a constant value that conforms to the return type (String).
> The few classes that check for the document Id being null (fewer than 50%) must be updated
accordingly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message