ctakes-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CTAKES-253) YTEX ctakes patches port
Date Wed, 04 Jun 2014 20:47:01 GMT

    [ https://issues.apache.org/jira/browse/CTAKES-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14018150#comment-14018150

ASF subversion and git services commented on CTAKES-253:

Commit 1600490 from chenpei@apache.org in branch 'ctakes/trunk'
[ https://svn.apache.org/r1600490 ]

CTAKES-253 CTAKES-292 - Integrate YTEX with cTAKES
1)	Removed <finalName> from ctakes-ytex-web.  This caused the jars to be called ctakes-ytex-web.jar
instead of the  default ctakes-ytex-web-{version}.jar.  Which will make downstream modules
fail to recognize this if added as a dependency.
2)	Removed the custom make-jar inside ctakes-ytext-web.  Use built-in attachClasses attribute
from war plugin instead.
a.	My guess is that you would like to jar all of the classes as well as have a war file. 
If true, then there is a feature already built-in for this.  I noticed there are other xml
properties included in the classes.  Let me know if there was still a specific reason for
the custom jar that I may have overlooked.
                By doing this, other modules can now depend on this by simply including the
classes classifier.  For example, in the distribution module:

> YTEX ctakes patches port
> ------------------------
>                 Key: CTAKES-253
>                 URL: https://issues.apache.org/jira/browse/CTAKES-253
>             Project: cTAKES
>          Issue Type: Bug
>          Components: ctakes-core
>    Affects Versions: 3.1.0
>         Environment: platform independent
>            Reporter: vijay
>            Assignee: Pei Chen
>             Fix For: 3.1.1
>         Attachments: jira-ctakes-core.zip
> This patch contains a variety of hardening fixes from the ytex distribution for ctakes
(originally developed for ctakes 2.5, but the bugs remain in ctakes 3.2).
> * ctakes-context-tokenizer\src\main\java\org\apache\ctakes\contexttokenizer\ae\ContextDependentTokenizerAnnotator.java
> add null check: changed to avoid NPE in case BaseToken is null.  Also ignore newline
tokens (they should be treated as whitespace).
> * ctakes-core\src\main\java\org\apache\ctakes\core\fsm\adapters\NumberTokenAdapter.java
> add null check: ignore empty numbertokens
> * ctakes-core\src\main\java\org\apache\ctakes\core\fsm\machine\DateFSM.java
> Modified to include years in dates

This message was sent by Atlassian JIRA

View raw message