ctakes-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Joseph Masanz (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CTAKES-278) UMLS user and password should be validated
Date Mon, 23 Dec 2013 17:11:50 GMT

    [ https://issues.apache.org/jira/browse/CTAKES-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855771#comment-13855771
] 

James Joseph Masanz commented on CTAKES-278:
--------------------------------------------


Since you are using trunk, it looks like the error checking or exception handling is not complete.


There must be a case where it is trying to URL encode null.

So it is a valid issue after all.

Thanks for opening this.




> UMLS user and password should be validated
> ------------------------------------------
>
>                 Key: CTAKES-278
>                 URL: https://issues.apache.org/jira/browse/CTAKES-278
>             Project: cTAKES
>          Issue Type: Improvement
>          Components: ctakes-dictionary-lookup
>    Affects Versions: future enhancement
>            Reporter: Chen Lin
>            Priority: Minor
>
> If the umls user name and password are not set properly, now the dictionary-lookup module
will throw NullPointerException, which is not very informative. isValidUMLSUser should validate
input and raise an informative exception instead.
> Caused by: java.lang.NullPointerException 
>          at java.net.URLEncoder.encode(URLEncoder.java:188) 
>          at org.apache.ctakes.dictionary.lookup.ae.UmlsDictionaryLookupAnnotator.isValidUMLSUser(UmlsDictionaryLookupAnnotator.java:87)

>          at org.apache.ctakes.dictionary.lookup.ae.UmlsDictionaryLookupAnnotator.initialize(UmlsDictionaryLookupAnnotator.java:70)

> Many thanks!



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message