Return-Path: X-Original-To: apmail-ctakes-notifications-archive@www.apache.org Delivered-To: apmail-ctakes-notifications-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 20FB71073B for ; Mon, 26 Aug 2013 15:27:53 +0000 (UTC) Received: (qmail 95596 invoked by uid 500); 26 Aug 2013 15:27:52 -0000 Delivered-To: apmail-ctakes-notifications-archive@ctakes.apache.org Received: (qmail 95564 invoked by uid 500); 26 Aug 2013 15:27:52 -0000 Mailing-List: contact notifications-help@ctakes.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ctakes.apache.org Delivered-To: mailing list notifications@ctakes.apache.org Received: (qmail 95417 invoked by uid 99); 26 Aug 2013 15:27:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Aug 2013 15:27:51 +0000 Date: Mon, 26 Aug 2013 15:27:51 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: notifications@ctakes.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CTAKES-209) Simplify how SentenceDetector models are loaded MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CTAKES-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13750150#comment-13750150 ] ASF subversion and git services commented on CTAKES-209: -------------------------------------------------------- Commit 1517558 from james-masanz@apache.org in branch 'ctakes/branches/ctakes-3.1.0' [ https://svn.apache.org/r1517558 ] merge CTAKES-209 revision 1517555 > Simplify how SentenceDetector models are loaded > ----------------------------------------------- > > Key: CTAKES-209 > URL: https://issues.apache.org/jira/browse/CTAKES-209 > Project: cTAKES > Issue Type: Improvement > Components: ctakes-core > Affects Versions: 3.0-incubating > Reporter: Pei Chen > Assignee: Pei Chen > Priority: Minor > Fix For: 3.1 > > > Sentence Dectector is still using the OpenNLP 1.4 mechanism of loading it's model file. > a. Suggestion: Let's update it to use the new 1.5 way similar to POSTagger. > - Remove non longer required classes: SuffixMaxentModelResourceImpl, MaxentModelResource, SuffixSensitiveGISModelReader, classes etc. > I think this will keep it consistent with the other projects such as POSTagger. > There may have been a performance reason for shared resources, but this is a tiny model compared to the others, and it's only done once during init time. This should simplify the code and it's references significantly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira