ctakes-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CTAKES-97) Remove unnecesssary OpenNLP tag dictionaries- it's built into the model since 1.5.x now- Thanks Joern
Date Mon, 08 Jul 2013 22:29:49 GMT

    [ https://issues.apache.org/jira/browse/CTAKES-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13702538#comment-13702538
] 

ASF subversion and git services commented on CTAKES-97:
-------------------------------------------------------

Commit 1500993 from chenpei@apache.org
[ https://svn.apache.org/r1500993 ]

CTAKES-97 - Since OpenNLP 1.5+, there is no need to load up the tag dictionary anymore.
Removing unnecessary/unused bit of code.
Forgot to check in the unused tagdictionary from referencing projects.
                
> Remove unnecesssary OpenNLP tag dictionaries- it's built into the model since 1.5.x now-
Thanks Joern
> -----------------------------------------------------------------------------------------------------
>
>                 Key: CTAKES-97
>                 URL: https://issues.apache.org/jira/browse/CTAKES-97
>             Project: cTAKES
>          Issue Type: Bug
>          Components: ctakes-pos-tagger
>    Affects Versions: 3.0-incubating
>            Reporter: Pei Chen
>            Assignee: Pei Chen
>            Priority: Minor
>             Fix For: 3.1
>
>
> We should be able to remove unused code now (tag dictionaries):
> For example- in the POSTagger
> //			boolean caseSensitive = (Boolean) uimaContext.getConfigParameterValue(CASE_SENSITIVE_PARAM);
> //			String tagDictionaryPath = (String) uimaContext.getConfigParameterValue(TAG_DICTIONARY_PARAM);
> //			TagDictionary tagDictionary = null;
> //			if (tagDictionaryPath != null && !tagDictionaryPath.trim().equals("")) {
> //				File tagDictFile = FileLocator.locateFile(tagDictionaryPath);
> //				String tagDictFileAbsPath = tagDictFile.getAbsolutePath();
> //				logger.info("POS tagger tag-dictionary: " + tagDictFileAbsPath);
> //
> //				tagDictionary = new POSDictionary(tagDictFileAbsPath, caseSensitive);
> //			} else {
> //				logger.info("No POS tagger tag-dictionary.");
> //			}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message