ctakes-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steven Bethard (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CTAKES-57) Type System updates for 3.x-incubating
Date Sat, 16 Feb 2013 19:35:12 GMT

    [ https://issues.apache.org/jira/browse/CTAKES-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13580005#comment-13580005
] 

Steven Bethard commented on CTAKES-57:
--------------------------------------

There's also this issue from the mailing list:

http://mail-archives.apache.org/mod_mbox/incubator-ctakes-dev/201302.mbox/%3CDAD9F0A4-13FC-4EA2-A9B4-54397558A649%40colorado.edu%3E

Both XXXModifer and XXX (Attribute) have identical methods for setting the normalized form
(getValue, getUnit, getNumber, etc.). That leads to code duplication like:

        ProcedureMethodModifier modifier = new ProcedureMethodModifier(jCas, ...);
        modifier.setValue(code);
        ProcedureMethod method = new ProcedureMethod(jCas);
        method.setValue(code);
        modifier.setNormalizedForm(method);

The suggestion on the mailing list is to remove the getValue/setValue etc. methods on the
XXXModifiers, and only set these things on the Attribute (the "NormalizedForm" feature of
the XXXModifier).
                
> Type System updates for 3.x-incubating
> --------------------------------------
>
>                 Key: CTAKES-57
>                 URL: https://issues.apache.org/jira/browse/CTAKES-57
>             Project: cTAKES
>          Issue Type: Improvement
>    Affects Versions: 3.0-incubating
>            Reporter: James Joseph Masanz
>            Assignee: James Joseph Masanz
>             Fix For: 3.1-incubating
>
>
> Opening 2 issues regarding the type system. This one is for changes that will require
refactoring and may affect current users.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message