ctakes-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Masanz, James J." <Masanz.Ja...@mayo.edu>
Subject RE: [jira] [Created] (CTAKES-278) UMLS user and password should be validated
Date Mon, 23 Dec 2013 17:08:25 GMT

Since you are using trunk, it looks like the error checking or exception handling is not complete.


There must be a case where it is trying to URL encode null.

So it is a valid issue after all.

Thanks for opening this.


-----Original Message-----
From: dev-return-2348-Masanz.James=mayo.edu@ctakes.apache.org [mailto:dev-return-2348-Masanz.James=mayo.edu@ctakes.apache.org]
On Behalf Of Lin, Chen
Sent: Monday, December 23, 2013 10:54 AM
To: dev@ctakes.apache.org
Subject: RE: [jira] [Created] (CTAKES-278) UMLS user and password should be validated

Thank you! It is good to know. I am using trunk, at r1548332.

Best,
Chen

-----Original Message-----
From: Masanz, James J. [mailto:Masanz.James@mayo.edu] 
Sent: Monday, December 23, 2013 11:51 AM
To: 'dev@ctakes.apache.org'
Subject: RE: [jira] [Created] (CTAKES-278) UMLS user and password should be validated


Hi Chen,

Which version of cTAKES are you seeing this in?

There is code in trunk and in the 3.1.1 branch [1] that at least throws an Exception stating
it is Invalid UMLS License:

   throw new Exception("Failed to initilize.  Invalid UMLS License");

[1] http://svn.apache.org/viewvc/ctakes/branches/ctakes-3.1.1/ctakes-dictionary-lookup/src/main/java/org/apache/ctakes/dictionary/lookup/ae/UmlsDictionaryLookupAnnotator.java?revision=1541928&view=markup

-- James

-----Original Message-----
From: notifications-return-1258-Masanz.James=mayo.edu@ctakes.apache.org [mailto:notifications-return-1258-Masanz.James=mayo.edu@ctakes.apache.org]
On Behalf Of Chen Lin (JIRA)
Sent: Monday, December 23, 2013 10:32 AM
To: notifications@ctakes.apache.org
Subject: [jira] [Created] (CTAKES-278) UMLS user and password should be validated

Chen Lin created CTAKES-278:
-------------------------------

             Summary: UMLS user and password should be validated
                 Key: CTAKES-278
                 URL: https://issues.apache.org/jira/browse/CTAKES-278
             Project: cTAKES
          Issue Type: Improvement
          Components: ctakes-dictionary-lookup
    Affects Versions: future enhancement
            Reporter: Chen Lin
            Priority: Minor


If the umls user name and password are not set properly, now the dictionary-lookup module
will throw NullPointerException, which is not very informative. isValidUMLSUser should validate
input and raise an informative exception instead.

Caused by: java.lang.NullPointerException 
         at java.net.URLEncoder.encode(URLEncoder.java:188) 
         at org.apache.ctakes.dictionary.lookup.ae.UmlsDictionaryLookupAnnotator.isValidUMLSUser(UmlsDictionaryLookupAnnotator.java:87)

         at org.apache.ctakes.dictionary.lookup.ae.UmlsDictionaryLookupAnnotator.initialize(UmlsDictionaryLookupAnnotator.java:70)


Many thanks!



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
Mime
View raw message