Mailing-List: contact dev-help@ctakes.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@ctakes.apache.org
Received-SPF: pass (athena.apache.org: domain of
 Pei.Chen@childrens.harvard.edu designates 134.174.13.91 as permitted sender)
From: "Chen, Pei" <Pei.Chen@childrens.harvard.edu>
To: "dev@ctakes.apache.org" <dev@ctakes.apache.org>,
        samir chabou
	<samirchb@yahoo.com>
Subject: RE: sentence number in  WordToken
Thread-Topic: sentence number in  WordToken
Thread-Index: AQHOvefjt1tzxr3TCEq7EQr7uXNqMJneszcA//++DwA=
Date: Mon, 30 Sep 2013 16:10:45 +0000
Message-ID: <924DE05C19409B438EB81DE683A942D9105B4950@CHEXMBX1A.CHBOSTON.ORG>
References: <0807E0585CEFC14283D2E8C1DF754EAFA853EE@WN35105.or.providence.org>
	<E084D8EFE2B03A408B324458C5212E94211F0AA7@CHEXMBX3A.CHBOSTON.ORG>
	<CAPqz87qJ6z9=hkuiDBvR8kV=w0p4icOsfr0q+EjV_vGuR_Np_w@mail.gmail.com>
	<E084D8EFE2B03A408B324458C5212E94211F0BC7@CHEXMBX3A.CHBOSTON.ORG>
	<CAPqz87pVQbPMFsBSpWUBcrD9v-9r5WAP5ZTs0Q67LJ+6Fs5rrQ@mail.gmail.com>
	<0807E0585CEFC14283D2E8C1DF754EAFA85980@WN35105.or.providence.org>
	<CAPqz87pky49YMf9ZpvvyER=mL2QvLs1jhpLy7U0SFpoyW6kRJg@mail.gmail.com>
	<408DC50FFBCBF347AF879E35BE1A70BC7CB8F6B51F@NYCWPRDADCMBX01.ahm.corp>
	<E084D8EFE2B03A408B324458C5212E94211FC570@CHEXMBX3A.CHBOSTON.ORG>
	<408DC50FFBCBF347AF879E35BE1A70BC7CB93F3600@NYCWPRDADCMBX01.ahm.corp>
	<CAPqz87pbHUNK=URhkoLxuqKBySwgqLJv7h3w+T_L74Taict9qA@mail.gmail.com>
 <CAPqz87qSbrNn=AW_eCNFrGu2M1xvDb=xzXcwtb34VrjAFXvvMQ@mail.gmail.com>
 <1380550643.17319.YahooMailNeo@web140303.mail.bf1.yahoo.com>
 <EB329886-DF19-4982-A080-349CE03A99B5@apache.org>
In-Reply-To: <EB329886-DF19-4982-A080-349CE03A99B5@apache.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

Samir,
I think Richard has a good point here.   What is the use to require adding =
sentenceNumber() to BaseToken in the TypeSystem?
If it's only temporary, It may be a good idea to do it programmatically wit=
h local variable rather than modifying the type system and having it stored=
 in the CAS...?

Maybe something like:
boolean a =3D JCasUtil.isCovered(JCas, BaseToken1, Sentence.class);
Boolean b =3D JCasUtil.isCovered(JCas, BaseToken2, Sentence.class);
--Pei


> -----Original Message-----
> From: Richard Eckart de Castilho [mailto:rec@apache.org]
> Sent: Monday, September 30, 2013 11:59 AM
> To: dev@ctakes.apache.org; samir chabou
> Subject: Re: sentence number in WordToken
>=20
> Hi,
>=20
> if you do many selectCovering calls, you may be faster using indexCoverin=
g
> once and then using the lookup index it produces.
>=20
> IMHO type systems should not contain information that can easily be
> calculated at runtime (e.g. sentence number, token number, etc.).
>=20
> Mind, I have no say here ;) Just my personal opinion.
>=20
> -- Richard
>=20
> On 30.09.2013, at 16:17, samir chabou <samirchb@yahoo.com> wrote:
>=20
> > Hi Pei,
> >
> > I though
> > this may be have some use ...
> >
> > Because I
> > need to know if two or more words tokens belong to the same sentence;
> > and since WordToken does not define the feature sentence number. I
> > added it to the TypeSystem. These are the steps:
> >
> > 1)      I added the sentence number
> > features for the type BaseToken in TypeSystem.xml file (I choose the
> > supper class in order that the feature be propagated to all subclasses
> > (wordToken,SymboleToken,NumToken ...)
> >
> > 2)      In ctakes-core I in TokenizerAnnotatorPTB.java (methode
> annotateRange) I set the new feature
> > (BaseToken.sentenceNumber =3D sentence.getSentenceNumber()) as
> shown below :
> >
> > bta.setSentenceNumber(sentence.getSentenceNumber());
> >       bta.addToIndexes();
> >
> > 3)      Generate the JCASGen in the tab de TypeSystem of the
> > aggregate
> >
> > 4)      Add the feature in the source
> > tab of the aggregate
> >
> > Probably I
> > could have used as alternative:
> > List<Sentence> list =3D JCasUtil.selectCovering(aJcas, Sentence.class,
> > entity1.getBegin(), entity1.getEnd()); the issue with this is : if I
> > have many entities to be checked at the same time or if the entity1 is
> > found in many places, I have to add some if conditions to get sentence
> > number
> >
> >
> > Thanks
> > Samir