Return-Path: X-Original-To: apmail-ctakes-commits-archive@www.apache.org Delivered-To: apmail-ctakes-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0652310351 for ; Mon, 15 Dec 2014 16:28:40 +0000 (UTC) Received: (qmail 40818 invoked by uid 500); 15 Dec 2014 16:28:39 -0000 Delivered-To: apmail-ctakes-commits-archive@ctakes.apache.org Received: (qmail 40783 invoked by uid 500); 15 Dec 2014 16:28:39 -0000 Mailing-List: contact commits-help@ctakes.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@ctakes.apache.org Delivered-To: mailing list commits@ctakes.apache.org Received: (qmail 40773 invoked by uid 99); 15 Dec 2014 16:28:39 -0000 Received: from eris.apache.org (HELO hades.apache.org) (140.211.11.105) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Dec 2014 16:28:39 +0000 Received: from hades.apache.org (localhost [127.0.0.1]) by hades.apache.org (ASF Mail Server at hades.apache.org) with ESMTP id 3B80EAC08CB; Mon, 15 Dec 2014 16:28:38 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r1645692 - /ctakes/trunk/ctakes-relation-extractor/src/main/java/org/apache/ctakes/relationextractor/ae/RelationExtractorAnnotator.java Date: Mon, 15 Dec 2014 16:28:38 -0000 To: commits@ctakes.apache.org From: clin@apache.org X-Mailer: svnmailer-1.0.9 Message-Id: <20141215162839.3B80EAC08CB@hades.apache.org> Author: clin Date: Mon Dec 15 16:28:38 2014 New Revision: 1645692 URL: http://svn.apache.org/r1645692 Log: add null check before feature extraction. Modified: ctakes/trunk/ctakes-relation-extractor/src/main/java/org/apache/ctakes/relationextractor/ae/RelationExtractorAnnotator.java Modified: ctakes/trunk/ctakes-relation-extractor/src/main/java/org/apache/ctakes/relationextractor/ae/RelationExtractorAnnotator.java URL: http://svn.apache.org/viewvc/ctakes/trunk/ctakes-relation-extractor/src/main/java/org/apache/ctakes/relationextractor/ae/RelationExtractorAnnotator.java?rev=1645692&r1=1645691&r2=1645692&view=diff ============================================================================== --- ctakes/trunk/ctakes-relation-extractor/src/main/java/org/apache/ctakes/relationextractor/ae/RelationExtractorAnnotator.java (original) +++ ctakes/trunk/ctakes-relation-extractor/src/main/java/org/apache/ctakes/relationextractor/ae/RelationExtractorAnnotator.java Mon Dec 15 16:28:38 2014 @@ -50,6 +50,7 @@ import org.cleartk.ml.CleartkProcessingE import org.cleartk.ml.Feature; import org.cleartk.ml.Instance; import org.cleartk.ml.jar.GenericJarClassifierFactory; +import org.cleartk.util.ViewUriUtil; import com.google.common.collect.Lists; @@ -147,7 +148,13 @@ public abstract class RelationExtractorA Annotation arg1 = relation.getArg1().getArgument(); Annotation arg2 = relation.getArg2().getArgument(); // The key is a list of args so we can do bi-directional lookup - relationLookup.put(Arrays.asList(arg1, arg2), relation); + List key = Arrays.asList(arg1, arg2); + if(relationLookup.containsKey(key)){ + String reln = relationLookup.get(key).getCategory(); + System.err.println("Error in: "+ ViewUriUtil.getURI(jCas).toString()); + System.err.println("Error! This attempted relation " + relation.getCategory() + " already has a relation " + reln + " at this span: " + arg1.getCoveredText() + " -- " + arg2.getCoveredText()); + } + relationLookup.put(key, relation); } } @@ -165,7 +172,8 @@ public abstract class RelationExtractorA // apply all the feature extractors to extract the list of features List features = new ArrayList<>(); for (RelationFeaturesExtractor extractor : this.featureExtractors) { - features.addAll(extractor.extract(jCas, arg1, arg2)); + List feats = extractor.extract(jCas, arg1, arg2); + if (feats != null) features.addAll(feats); } // sanity check on feature values