Mailing-List: contact user-help@crunch.apache.org; run by ezmlm
Precedence: bulk
Reply-To: user@crunch.apache.org
MIME-Version: 1.0
In-Reply-To: <e7d46d390c6fbb4cea1a07b1a594bfce@webmail.webfaction.com>
References: <e7d46d390c6fbb4cea1a07b1a594bfce@webmail.webfaction.com>
From: Josh Wills <josh.wills@gmail.com>
Date: Mon, 18 Jul 2016 08:24:12 -0700
Message-ID: <CANb5z2K=XTMOnwwpwoyBrQKO2dBK5oKJ8Wv0pCtLDeEPVd-VUA@mail.gmail.com>
Subject: Re: Should AvroReflectDeepCopier require a public ctor ?
To: "user@crunch.apache.org" <user@crunch.apache.org>
Content-Type: multipart/alternative; boundary=94eb2c03b5f89a5b910537ea901c
archived-at: Mon, 18 Jul 2016 15:24:50 -0000

--94eb2c03b5f89a5b910537ea901c
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hey Clement,

I _believe_ that is a requirement of Avro reflection-based serialization,
at least it was at the time we originally implemented the functionality. If
that is no longer the case, we can change it.

J

On Mon, Jul 18, 2016 at 4:31 AM, Cl=C3=A9ment MATHIEU <clement@unportant.in=
fo>
wrote:

> Hi,
>
> I noticed that AvroReflectDeepCopier mandates a public no-arg ctor while
> most features don't care about ctor accessibility (ie. Avro reflect /
> deepCopy, ReflectionUtils etc.).
>
> Is there a special reason to this ? If not, it seems like a two lines fix=
.
>
> Thanks,
> Cl=C3=A9ment
>

--94eb2c03b5f89a5b910537ea901c
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hey Clement,<div><br></div><div>I _believe_ that is a requ=
irement of Avro reflection-based serialization, at least it was at the time=
 we originally implemented the functionality. If that is no longer the case=
, we can change it.</div><div><br></div><div>J</div><div class=3D"gmail_ext=
ra"><br><div class=3D"gmail_quote">On Mon, Jul 18, 2016 at 4:31 AM, Cl=C3=
=A9ment MATHIEU <span dir=3D"ltr">&lt;<a href=3D"mailto:clement@unportant.i=
nfo" target=3D"_blank">clement@unportant.info</a>&gt;</span> wrote:<br><blo=
ckquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #c=
cc solid;padding-left:1ex">Hi,<br>
<br>
I noticed that AvroReflectDeepCopier mandates a public no-arg ctor while mo=
st features don&#39;t care about ctor accessibility (ie. Avro reflect / dee=
pCopy, ReflectionUtils etc.).<br>
<br>
Is there a special reason to this ? If not, it seems like a two lines fix.<=
br>
<br>
Thanks,<br>
Cl=C3=A9ment<br>
</blockquote></div><br></div></div>

--94eb2c03b5f89a5b910537ea901c--