crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Patel (JIRA)" <j...@apache.org>
Subject [jira] [Created] (CRUNCH-639) Writable Bytes does an unnecessary copy
Date Fri, 10 Mar 2017 22:40:04 GMT
Stephen Patel created CRUNCH-639:
------------------------------------

             Summary: Writable Bytes does an unnecessary copy
                 Key: CRUNCH-639
                 URL: https://issues.apache.org/jira/browse/CRUNCH-639
             Project: Crunch
          Issue Type: Improvement
          Components: Core
            Reporter: Stephen Patel
            Assignee: Josh Wills
            Priority: Minor


In the Writable.bytes() Output MapFn, an unnecessary (I believe) copy of the incoming ByteBuffer
occurs[0].

Current:
{code}
BytesWritable bw = new BytesWritable();
bw.set(input.array(), input.arrayOffset(), input.limit()); <- copies the array
{code}

Proposed:
{code}
BytesWritable bw = new BytesWritable(input.array()); 
{code}

[0]: https://github.com/apache/crunch/blob/apache-crunch-0.15.0/crunch-core/src/main/java/org/apache/crunch/types/writable/Writables.java#L271



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message