Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6B5C8200B43 for ; Tue, 19 Jul 2016 21:01:22 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 6A1C1160A5C; Tue, 19 Jul 2016 19:01:22 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D1700160A8F for ; Tue, 19 Jul 2016 21:01:21 +0200 (CEST) Received: (qmail 85487 invoked by uid 500); 19 Jul 2016 19:01:21 -0000 Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list dev@crunch.apache.org Received: (qmail 85370 invoked by uid 500); 19 Jul 2016 19:01:20 -0000 Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org Received: (qmail 85359 invoked by uid 99); 19 Jul 2016 19:01:20 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jul 2016 19:01:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BDC322C0D60 for ; Tue, 19 Jul 2016 19:01:20 +0000 (UTC) Date: Tue, 19 Jul 2016 19:01:20 +0000 (UTC) From: =?utf-8?Q?Cl=C3=A9ment_MATHIEU_=28JIRA=29?= To: crunch-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CRUNCH-612) Add support of private constructors to Avros.reflect MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 19 Jul 2016 19:01:22 -0000 Cl=C3=A9ment MATHIEU created CRUNCH-612: -------------------------------------- Summary: Add support of private constructors to Avros.reflect= =20 Key: CRUNCH-612 URL: https://issues.apache.org/jira/browse/CRUNCH-612 Project: Crunch Issue Type: Improvement Components: Core Reporter: Cl=C3=A9ment MATHIEU Assignee: Josh Wills While Avro reflect supports private no-arg constructors since at least 1.4.= 0, see [this test case|https://gist.github.com/cykl/bf8936fca0410d0cea61402= bf5b1e5f9], Crunch mandates this constructor to be public for deep copy. It= seems like an unfortunate shortcoming rather than a conscious choice.=20 Since hiding the mandatory no-arg constructor can be quite useful to avoid = API pollution, let's patch AvroDeepCopier to add support of private ctor.= =20 -- This message was sent by Atlassian JIRA (v6.3.4#6332)