crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micah Whitacre (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CRUNCH-612) Add support of private constructors to Avros.reflect
Date Fri, 29 Jul 2016 21:55:20 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Micah Whitacre updated CRUNCH-612:
----------------------------------
    Fix Version/s: 0.15.0

> Add support of private constructors to Avros.reflect 
> -----------------------------------------------------
>
>                 Key: CRUNCH-612
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-612
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Clément MATHIEU
>            Assignee: Josh Wills
>             Fix For: 0.15.0
>
>         Attachments: CRUNCH-612.patch
>
>
> While Avro reflect supports private no-arg constructors since at least 1.4.0, see [this
test case|https://gist.github.com/cykl/bf8936fca0410d0cea61402bf5b1e5f9], Crunch mandates
this constructor to be public for deep copy. It seems like an unfortunate shortcoming rather
than a conscious choice. 
> Since hiding the mandatory no-arg constructor can be quite useful to avoid API pollution,
let's patch AvroDeepCopier to add support of private ctor. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message