Return-Path: X-Original-To: apmail-crunch-dev-archive@www.apache.org Delivered-To: apmail-crunch-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9E20A1838E for ; Tue, 22 Mar 2016 13:29:27 +0000 (UTC) Received: (qmail 23288 invoked by uid 500); 22 Mar 2016 13:29:27 -0000 Delivered-To: apmail-crunch-dev-archive@crunch.apache.org Received: (qmail 23121 invoked by uid 500); 22 Mar 2016 13:29:26 -0000 Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list dev@crunch.apache.org Received: (qmail 22939 invoked by uid 500); 22 Mar 2016 13:29:25 -0000 Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org Received: (qmail 22895 invoked by uid 99); 22 Mar 2016 13:29:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 Mar 2016 13:29:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 77BE22C1F5D for ; Tue, 22 Mar 2016 13:29:25 +0000 (UTC) Date: Tue, 22 Mar 2016 13:29:25 +0000 (UTC) From: "Gabriel Reid (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CRUNCH-596) Right and full outer join for Bloom filter strategy MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206343#comment-15206343 ] Gabriel Reid commented on CRUNCH-596: ------------------------------------- {quote}I was not sure about this IdentityFn change. Can you explain little bit why do you prefer not to loose access to constructor? {quote} Yeah, sorry I didn't mention that change that I made related to the IdentityFn. It just seemed like there wasn't much to be won by extending IdentityFn, and breaking the concept of IdentityFn being only accessible via a static method didn't seem worth it (i.e. it would make it less automatically clear how IdentityFn is to be used). > Right and full outer join for Bloom filter strategy > --------------------------------------------------- > > Key: CRUNCH-596 > URL: https://issues.apache.org/jira/browse/CRUNCH-596 > Project: Crunch > Issue Type: Improvement > Components: Core > Affects Versions: 0.13.0 > Reporter: Piotr Chromiec > Assignee: Gabriel Reid > Priority: Minor > Labels: features, github-import, newbie > Fix For: 0.14.0 > > > Seems that current Bloom filter join strategy lacks of support for right and full outer joins. At RTBHOUSE we had recently found this as useful and implemented for our internal project. Code for this feature with javadoc and tests is pushed at GitHub [PullRequest#9|https://github.com/apache/crunch/pull/9] > I'm newbie here so forgive me if this issue is somehow incomplete or buggy. -- This message was sent by Atlassian JIRA (v6.3.4#6332)