crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-596) Right and full outer join for Bloom filter strategy
Date Tue, 22 Mar 2016 13:29:25 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15206343#comment-15206343
] 

Gabriel Reid commented on CRUNCH-596:
-------------------------------------

{quote}I was not sure about this IdentityFn change. Can you explain little bit why do you
prefer not to loose access to constructor?
{quote}

Yeah, sorry I didn't mention that change that I made related to the IdentityFn. It just seemed
like there wasn't much to be won by extending IdentityFn, and breaking the concept of IdentityFn
being only accessible via a static method didn't seem worth it (i.e. it would make it less
automatically clear how IdentityFn is to be used).

> Right and full outer join for Bloom filter strategy
> ---------------------------------------------------
>
>                 Key: CRUNCH-596
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-596
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.13.0
>            Reporter: Piotr Chromiec
>            Assignee: Gabriel Reid
>            Priority: Minor
>              Labels: features, github-import, newbie
>             Fix For: 0.14.0
>
>
> Seems that current Bloom filter join strategy lacks of support for right and full outer
joins. At RTBHOUSE we had recently found this as useful and implemented for our internal project.
Code for this feature with javadoc and tests is pushed at GitHub [PullRequest#9|https://github.com/apache/crunch/pull/9]
> I'm newbie here so forgive me if this issue is somehow incomplete or buggy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message