crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micah Whitacre (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-356) Replace deprecated Closeables.closeQuietly with explicit IOException handling
Date Sun, 06 Dec 2015 22:42:10 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15044183#comment-15044183
] 

Micah Whitacre commented on CRUNCH-356:
---------------------------------------

Logged "competing" JIRAs to either upgrade the Guava dependency or remove it all together.

Personally in favor of removing as seems like most other projects have done that as well.
 We also aren't using anything too extreme besides copying files and some of the collections
API.

> Replace deprecated Closeables.closeQuietly with explicit IOException handling
> -----------------------------------------------------------------------------
>
>                 Key: CRUNCH-356
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-356
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: John Leacox
>            Assignee: Josh Wills
>            Priority: Minor
>         Attachments: CRUNCH-356.patch, CRUNCH-356.patch, patch.diff, patch2.diff
>
>
> Closeables.closeQuietly was deprecated in Guava 13 and removed in Guava 16. If a consumer
of crunch-core is using Guava 16+ a NoSuchMethodError could occur where Closeables.closeQuietly
is being used.
> Uses of Closeable.closeQuietly should be replaced with explicit handling of IOException
with logging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message