Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@crunch.apache.org
Date: Fri, 2 Oct 2015 20:09:26 +0000 (UTC)
From: "Sean Owen (JIRA)" <jira@apache.org>
To: crunch-dev@incubator.apache.org
Message-ID: <JIRA.12902194.1443816544000.13407.1443816566712@Atlassian.JIRA>
In-Reply-To: <JIRA.12902194.1443816544000@Atlassian.JIRA>
References: <JIRA.12902194.1443816544000@Atlassian.JIRA>
 <JIRA.12902194.1443816544761@arcas>
Subject: [jira] [Created] (CRUNCH-567) close() triggers NPE if initialize()
 fails in 2 classes
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Sean Owen created CRUNCH-567:
--------------------------------

             Summary: close() triggers NPE if initialize() fails in 2 classes
                 Key: CRUNCH-567
                 URL: https://issues.apache.org/jira/browse/CRUNCH-567
             Project: Crunch
          Issue Type: Bug
          Components: Core
    Affects Versions: 0.12.0
            Reporter: Sean Owen
            Assignee: Josh Wills
            Priority: Trivial


Quite trivial, but just noticed this on a customer project: in AvroRecordReader and HFileInputFormat, close() closes a reader object. However it will be null if initialize() is never called or fails to complete normally, generating an NPE. It ends up being an issue since their close() is called in some kind of finally block at some point.

Attaching a patch for now but do we do pull requests here now instead?


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)