crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Owen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CRUNCH-567) close() triggers NPE if initialize() fails in 2 classes
Date Fri, 02 Oct 2015 20:10:26 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sean Owen updated CRUNCH-567:
-----------------------------
    Attachment: CRUNCH-567.patch

> close() triggers NPE if initialize() fails in 2 classes
> -------------------------------------------------------
>
>                 Key: CRUNCH-567
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-567
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.12.0
>            Reporter: Sean Owen
>            Assignee: Josh Wills
>            Priority: Trivial
>         Attachments: CRUNCH-567.patch
>
>
> Quite trivial, but just noticed this on a customer project: in AvroRecordReader and HFileInputFormat,
close() closes a reader object. However it will be null if initialize() is never called or
fails to complete normally, generating an NPE. It ends up being an issue since their close()
is called in some kind of finally block at some point.
> Attaching a patch for now but do we do pull requests here now instead?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message