crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micah Whitacre (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-565) CSVInputFormat needs to be more defensive when configuring itself
Date Thu, 01 Oct 2015 19:55:26 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940306#comment-14940306
] 

Micah Whitacre commented on CRUNCH-565:
---------------------------------------

The patch does look good.  Haven't done full dive yet but to answer your question about setting
"null" you could tweak your code to either set a null value or "clear" the configuration object
before populating just the fields you want.

Also yes to just attaching patch to the JIRA workflow.  

> CSVInputFormat needs to be more defensive when configuring itself
> -----------------------------------------------------------------
>
>                 Key: CRUNCH-565
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-565
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.10.0, 0.8.3
>            Reporter: mac champion
>            Assignee: mac champion
>            Priority: Minor
>              Labels: csv, csvparser
>
> It seems that some behavior has changed somewhere along the line where hadoop Configuration
is concerned. It is possible that a call to .get(OPTION) will return null. CSVInputFormat
does not handle that case gracefully:
> https://github.com/apache/crunch/blob/apache-crunch-0.10.0/crunch-core/src/main/java/org/apache/crunch/io/text/csv/CSVInputFormat.java#L178-L183
> Some more relevant details can be found in this JIRA:
> https://issues.apache.org/jira/browse/CRUNCH-564?focusedCommentId=14938186&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14938186



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message