crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-562) Support one output file per key for Parquet
Date Wed, 23 Sep 2015 12:31:04 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14904427#comment-14904427
] 

Gabriel Reid commented on CRUNCH-562:
-------------------------------------

Patch looks pretty good to me. 

One minor thing I noticed (or actually my IDE noticed) is that line 101 of AvroParquetPathPerKeyTarget.handleOutputs
isn't necessary (the variable keys isn't used anywhere):
{code}
Path[] keys = FileUtil.stat2Paths(srcFs.listStatus(base));
{code}

I see that this same issue is present in AvroPathPerKeyTarget, which makes me wonder how easy
it would be to combine most of the general PathPerKey functionality into a single base class.

> Support one output file per key for Parquet
> -------------------------------------------
>
>                 Key: CRUNCH-562
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-562
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.12.0
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: CRUNCH-562.patch
>
>
> Add an equivalent of AvroPathPerKeyTarget (introduced in CRUNCH-306) for Parquet.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message