crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Wills (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-554) Add min and max aggregators for Comparables
Date Sat, 01 Aug 2015 15:31:04 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14650393#comment-14650393
] 

Josh Wills commented on CRUNCH-554:
-----------------------------------

Wow, that is much nicer. I'd like to leave the type-specific aggregator functions in place
w/o deprecation warnings, even though they just wrap the Max/MinComparables.

> Add min and max aggregators for Comparables
> -------------------------------------------
>
>                 Key: CRUNCH-554
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-554
>             Project: Crunch
>          Issue Type: New Feature
>            Reporter: Gabriel Reid
>            Assignee: Gabriel Reid
>         Attachments: CRUNCH-554.patch
>
>
> In the Aggregators class, we currently have min and max aggregators for various numeric
types, but not for the general case of Comparables. We do have this functionality in the MaxN
and MinN aggregators, however.
> We should add MAX_COMPARABLES and MIN_COMPARABLES methods to the Aggregators class. As
extra bonus, all of the current numeric max and min aggregators can be discarded and replaced
with the comparable version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message