Return-Path: 
 <dev-return-5578-apmail-crunch-dev-archive=crunch.apache.org@crunch.apache.org>
X-Original-To: apmail-crunch-dev-archive@www.apache.org
Delivered-To: apmail-crunch-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 691BB18F3C
	for <apmail-crunch-dev-archive@www.apache.org>;
 Wed, 29 Jul 2015 08:30:05 +0000 (UTC)
Received: (qmail 20058 invoked by uid 500); 29 Jul 2015 08:30:05 -0000
Delivered-To: apmail-crunch-dev-archive@crunch.apache.org
Received: (qmail 20012 invoked by uid 500); 29 Jul 2015 08:30:05 -0000
Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@crunch.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@crunch.apache.org>
List-Post: <mailto:dev@crunch.apache.org>
List-Id: <dev.crunch.apache.org>
Reply-To: dev@crunch.apache.org
Delivered-To: mailing list dev@crunch.apache.org
Received: (qmail 19946 invoked by uid 500); 29 Jul 2015 08:30:05 -0000
Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org
Received: (qmail 19941 invoked by uid 99); 29 Jul 2015 08:30:05 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jul 2015 08:30:05 +0000
Date: Wed, 29 Jul 2015 08:30:05 +0000 (UTC)
From: "Gabriel Reid (JIRA)" <jira@apache.org>
To: crunch-dev@incubator.apache.org
Message-ID: <JIRA.12849869.1438158394000.316641.1438158605239@Atlassian.JIRA>
In-Reply-To: <JIRA.12849869.1438158394000@Atlassian.JIRA>
References: <JIRA.12849869.1438158394000@Atlassian.JIRA>
 <JIRA.12849869.1438158394524@arcas>
Subject: [jira] [Updated] (CRUNCH-554) Add min and max aggregators for
 Comparables
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/CRUNCH-554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gabriel Reid updated CRUNCH-554:
--------------------------------
    Attachment: CRUNCH-554.patch

Patch to add MAX_COMPARABLES and MIN_COMPARABLES to the Aggregators class, also removes the existing min and max aggregators for various numeric types.

One extra thing I was considering was deprecating the MIN_<numeric type> and MAX_<numeric type> aggregators, with the suggestion to just use the MAX_COMPARABLES and MIN_COMPARABLES methods instead. Anyone have any thoughts either way on that?

> Add min and max aggregators for Comparables
> -------------------------------------------
>
>                 Key: CRUNCH-554
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-554
>             Project: Crunch
>          Issue Type: New Feature
>            Reporter: Gabriel Reid
>            Assignee: Gabriel Reid
>         Attachments: CRUNCH-554.patch
>
>
> In the Aggregators class, we currently have min and max aggregators for various numeric types, but not for the general case of Comparables. We do have this functionality in the MaxN and MinN aggregators, however.
> We should add MAX_COMPARABLES and MIN_COMPARABLES methods to the Aggregators class. As extra bonus, all of the current numeric max and min aggregators can be discarded and replaced with the comparable version.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)