crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <>
Subject [jira] [Resolved] (CRUNCH-546) Avoid CellUtil.cloneXXX in HFileUtils and HFileInputFormat
Date Mon, 20 Jul 2015 13:28:05 GMT


Gabriel Reid resolved CRUNCH-546.
       Resolution: Fixed
    Fix Version/s: 0.13.0

Pushed to master

> Avoid CellUtil.cloneXXX in HFileUtils and HFileInputFormat
> ----------------------------------------------------------
>                 Key: CRUNCH-546
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Gabriel Reid
>            Assignee: Gabriel Reid
>             Fix For: 0.13.0
>         Attachments: CRUNCH-546.patch
> HFileUtils and HFileInputFormat currently make use of the CellUtil.cloneXXX in a number
of places when comparing row, family, and qualifier values with a constant.
> The clone methods are relatively costly, as they require allocating a new byte array
and copying all data over into the new array on every call. 
> {{Bytes.equals}}, {{Bytes.compareTo}}, and {{ByteBuffer.wrap}} also accept a byte array
and offset and length parameters, which allows accessing portions of KeyValues without copying
them out into a separate byte array when using them for comparison. We should replace the
uses of CellUtil.cloneXXX with the alternate calls to the above methods where possible.

This message was sent by Atlassian JIRA

View raw message