Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@crunch.apache.org
Date: Fri, 22 May 2015 10:59:17 +0000 (UTC)
From: "Gabriel Reid (JIRA)" <jira@apache.org>
To: crunch-dev@incubator.apache.org
Message-ID: <JIRA.12831950.1432242038000.8981.1432292357859@Atlassian.JIRA>
In-Reply-To: <JIRA.12831950.1432242038000@Atlassian.JIRA>
References: <JIRA.12831950.1432242038000@Atlassian.JIRA>
 <JIRA.12831950.1432242038186@arcas>
Subject: [jira] [Commented] (CRUNCH-524) Tests leave hbase, test.h2.db files
 around; pipeline leaves temp crunch-xxx dirs around.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CRUNCH-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555975#comment-14555975 ] 

Gabriel Reid commented on CRUNCH-524:
-------------------------------------

{quote}You guys may know better than I where in the code these temp dirs could be explicitly cleaned up too. That's even better, rather than rely on a shutdown hook.{quote}

No, I think that this is the best option that I've seen for handling this. As far as I know, temp directories won't ever be left around if pipeline.done() or pipeline.cleanup() are called, but this condition doesn't always hold of course. Making use of a shutdown hook that is already in place to catch most of the other cases sounds fine to me. Looking at the code of deleteOnExit and friends, it looks like it'll be fine with a directory that doesn't exist anymore as well. I'll commit this shortly (unless anyone has anything against it).

> Tests leave hbase, test.h2.db files around; pipeline leaves temp crunch-xxx dirs around.
> ----------------------------------------------------------------------------------------
>
>                 Key: CRUNCH-524
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-524
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.12.0
>            Reporter: Sean Owen
>            Assignee: Josh Wills
>            Priority: Minor
>         Attachments: CRUNCH-524.patch
>
>
> Minor thing I noticed during running tests: I end up with an {{hbase/}} directory and {{test.h2.db}} file in my _home directory_. I think the tests can be changed to clean these up reliably or put them in a better place.
> Also I think we can get the {{/tmp/crunch-xxx}} dirs to be automatically deleted. I see a lot in my temp dir and this happens on a cluster's temp dir too.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)