crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-524) Tests leave hbase, test.h2.db files around; pipeline leaves temp crunch-xxx dirs around.
Date Fri, 22 May 2015 10:11:17 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555925#comment-14555925
] 

Gabriel Reid commented on CRUNCH-524:
-------------------------------------

+1

It would be great to clean up the hbase directory in the home dir. Wouldn't be bad to have
an error message in the assertFalse call where the check is done for a pre-existing hbase
directory under the home dir to avoid confusion -- and then on the other hand, the comments
there make it clear and nobody is going to be running that IT without direct access to the
code, so it should be fine as is.

The deleteOnExit stuff for the crunch-xxxx temp dir looks good too -- I believe that this
also resolves the general topic that [~jwills] and I were discussing at the end of CRUNCH-515.
I'm guessing that the deleteOnExit stuff in FileSystem also works with shutdown hooks, but
those shutdown hooks (or whatever) are there anyhow, so I'm guessing we can't get into any
extra trouble by making use of them.

> Tests leave hbase, test.h2.db files around; pipeline leaves temp crunch-xxx dirs around.
> ----------------------------------------------------------------------------------------
>
>                 Key: CRUNCH-524
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-524
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.12.0
>            Reporter: Sean Owen
>            Assignee: Josh Wills
>            Priority: Minor
>         Attachments: CRUNCH-524.patch
>
>
> Minor thing I noticed during running tests: I end up with an {{hbase/}} directory and
{{test.h2.db}} file in my _home directory_. I think the tests can be changed to clean these
up reliably or put them in a better place.
> Also I think we can get the {{/tmp/crunch-xxx}} dirs to be automatically deleted. I see
a lot in my temp dir and this happens on a cluster's temp dir too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message