Return-Path: X-Original-To: apmail-crunch-dev-archive@www.apache.org Delivered-To: apmail-crunch-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 13AF3176EA for ; Fri, 13 Feb 2015 14:58:12 +0000 (UTC) Received: (qmail 23496 invoked by uid 500); 13 Feb 2015 14:58:12 -0000 Delivered-To: apmail-crunch-dev-archive@crunch.apache.org Received: (qmail 23450 invoked by uid 500); 13 Feb 2015 14:58:12 -0000 Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list dev@crunch.apache.org Received: (qmail 23435 invoked by uid 500); 13 Feb 2015 14:58:11 -0000 Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org Received: (qmail 23432 invoked by uid 99); 13 Feb 2015 14:58:11 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Feb 2015 14:58:11 +0000 Date: Fri, 13 Feb 2015 14:58:11 +0000 (UTC) From: "Surbhi Mungre (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CRUNCH-494) Unable to union large number of PCollections MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320199#comment-14320199 ] Surbhi Mungre commented on CRUNCH-494: -------------------------------------- I tried this fix and it worked for 5000 PCollections. However, for 8000 PCollections I get following stack overflow exception. {noformat} java.lang.StackOverflowError at java.util.Arrays$ArrayList.size(Arrays.java:3362) at java.util.AbstractList$Itr.hasNext(AbstractList.java:339) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) at com.google.common.collect.Iterators$3.hasNext(Iterators.java:124) at com.google.common.collect.Iterators$5.hasNext(Iterators.java:543) {noformat} Following unit test can reproduce it. I am guessing it is coming from Sets.union method in PCollectionImpl class. https://gist.github.com/anonymous/a7f1ca3a91d2a4b49218 > Unable to union large number of PCollections > --------------------------------------------- > > Key: CRUNCH-494 > URL: https://issues.apache.org/jira/browse/CRUNCH-494 > Project: Crunch > Issue Type: Bug > Components: Core > Affects Versions: 0.8.3 > Reporter: Surbhi Mungre > Assignee: Josh Wills > Priority: Minor > Fix For: 0.12.0 > > Attachments: CRUNCH-494.patch > > > If you try to union large number of PCollections(~5K), then Crunch throws StackOverflowError exception. > {noformat} > java.lang.StackOverflowError > at com.google.common.collect.AbstractIndexedListIterator.(AbstractIndexedListIterator.java:68) > at com.google.common.collect.AbstractIndexedListIterator.(AbstractIndexedListIterator.java:54) > at com.google.common.collect.Iterators$12.(Iterators.java:1072) > at com.google.common.collect.Iterators.forArray(Iterators.java:1072) > at com.google.common.collect.RegularImmutableList.iterator(RegularImmutableList.java:68) > at com.google.common.collect.RegularImmutableList.iterator(RegularImmutableList.java:31) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:291) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > at org.apache.crunch.impl.dist.collect.PCollectionImpl.getTargetDependencies(PCollectionImpl.java:292) > {noformat} > Here is a simple test which can reproduce the issue. > https://gist.github.com/anonymous/22f08511604341d0ffda -- This message was sent by Atlassian JIRA (v6.3.4#6332)