crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allan Shoup (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-501) Object reuse issue in combineValues(Aggregator)
Date Mon, 23 Feb 2015 20:33:13 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333770#comment-14333770
] 

Allan Shoup commented on CRUNCH-501:
------------------------------------

Without looking at the code to see how hard it would actually be, is there a reason not to
provide access to the PType for every DoFn? I've wanted this before and having it available
without having to add code in my specific DoFn to pass in the PType would certainly be handy.

> Object reuse issue in combineValues(Aggregator)
> -----------------------------------------------
>
>                 Key: CRUNCH-501
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-501
>             Project: Crunch
>          Issue Type: Bug
>            Reporter: Brandon Davis
>
> I'm trying to use combineValues on a PGroupedTable. I am using Aggregators.FIRST_N. If
I have 20 keys in my PGroupedTable, then I only get 20 distinct values because the AggregatorCombineFn
and FirstNAggregator don't detach the values from the incoming iterator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message