Return-Path: X-Original-To: apmail-crunch-dev-archive@www.apache.org Delivered-To: apmail-crunch-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A46BF10B9B for ; Sat, 24 Jan 2015 20:18:34 +0000 (UTC) Received: (qmail 33519 invoked by uid 500); 24 Jan 2015 20:18:34 -0000 Delivered-To: apmail-crunch-dev-archive@crunch.apache.org Received: (qmail 33480 invoked by uid 500); 24 Jan 2015 20:18:34 -0000 Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list dev@crunch.apache.org Received: (qmail 33468 invoked by uid 500); 24 Jan 2015 20:18:34 -0000 Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org Received: (qmail 33465 invoked by uid 99); 24 Jan 2015 20:18:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 24 Jan 2015 20:18:34 +0000 Date: Sat, 24 Jan 2015 20:18:34 +0000 (UTC) From: "Josh Wills (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CRUNCH-489) Add methods to create PCollections from Java Iterable to Pipeline interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Wills updated CRUNCH-489: ------------------------------ Attachment: CRUNCH-489d.patch [~gabriel.reid] thanks for the review-- this patch addresses most of your comments. A couple of notes: 0) The import o.a.c.* was a bad default on IntelliJ on my new laptop-- all fixed. 1) NLineFileIT is still testing NLineInputSource by way of the create() interface, which uses an NLineInputSource for Writable text files. 2) I really like the idea of breaking up the contents of the Iterable into individual files and disabling combine file to make the parallelization work. I suppose I could either check to see if the Iterable was a Collection, and if so cache it into memory and split up the values into chunks, or if it was not, I could open P connections to HDFS and write one value into each output handle as I stream through the Iterable. What do you think here? > Add methods to create PCollections from Java Iterable to Pipeline interface > --------------------------------------------------------------------------- > > Key: CRUNCH-489 > URL: https://issues.apache.org/jira/browse/CRUNCH-489 > Project: Crunch > Issue Type: Bug > Reporter: Josh Wills > Attachments: CRUNCH-489.patch, CRUNCH-489b.patch, CRUNCH-489c.patch, CRUNCH-489d.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)