Return-Path: X-Original-To: apmail-crunch-dev-archive@www.apache.org Delivered-To: apmail-crunch-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 73B571091F for ; Mon, 12 Jan 2015 14:10:33 +0000 (UTC) Received: (qmail 4910 invoked by uid 500); 12 Jan 2015 14:10:34 -0000 Delivered-To: apmail-crunch-dev-archive@crunch.apache.org Received: (qmail 4857 invoked by uid 500); 12 Jan 2015 14:10:34 -0000 Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list dev@crunch.apache.org Received: (qmail 4842 invoked by uid 500); 12 Jan 2015 14:10:34 -0000 Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org Received: (qmail 4839 invoked by uid 99); 12 Jan 2015 14:10:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Jan 2015 14:10:34 +0000 Date: Mon, 12 Jan 2015 14:10:34 +0000 (UTC) From: "David Whiting (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (CRUNCH-484) Add library features from spotify/crunch-lib into crunch-core MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Whiting updated CRUNCH-484: --------------------------------- Attachment: CRUNCH-484c.patch Sorry about the delay, been taking one of those 3-week-long Swedish winter vacations. I've attached a patch based on (b) that changes comments and variables from percentiles to quantiles as well. > Add library features from spotify/crunch-lib into crunch-core > ------------------------------------------------------------- > > Key: CRUNCH-484 > URL: https://issues.apache.org/jira/browse/CRUNCH-484 > Project: Crunch > Issue Type: Improvement > Components: Core > Reporter: David Whiting > Assignee: Josh Wills > Attachments: 0001-CRUNCH-484-Add-library-features-from-spotify-crunch-.patch, CRUNCH-484.patch, CRUNCH-484b.patch, CRUNCH-484c.patch > > > As suggested by Josh, I've patched the more generally-applicable stuff from https://github.com/spotify/crunch-lib into org.apache.crunch.lib > Open questions: > - Does all of this belong here? > - Should Percentiles be renamed to Quantiles, given that you actually just specify a 0.0-1.0 range? Quantiles is more accurate, but people are more likely to search for Percentiles. > - Would the DoFns.detach(...) functionality be better implemented as a DetachingReduceFn base class rather than a wrap-and-delegate? -- This message was sent by Atlassian JIRA (v6.3.4#6332)