crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Whiting (JIRA)" <>
Subject [jira] [Updated] (CRUNCH-484) Add library features from spotify/crunch-lib into crunch-core
Date Mon, 12 Jan 2015 14:10:34 GMT


David Whiting updated CRUNCH-484:
    Attachment: CRUNCH-484c.patch

Sorry about the delay, been taking one of those 3-week-long Swedish winter vacations. I've
attached a patch based on (b) that changes comments and variables from percentiles to quantiles
as well.

> Add library features from spotify/crunch-lib into crunch-core
> -------------------------------------------------------------
>                 Key: CRUNCH-484
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: David Whiting
>            Assignee: Josh Wills
>         Attachments: 0001-CRUNCH-484-Add-library-features-from-spotify-crunch-.patch,
CRUNCH-484.patch, CRUNCH-484b.patch, CRUNCH-484c.patch
> As suggested by Josh, I've patched the more generally-applicable stuff from
into org.apache.crunch.lib
> Open questions:
> - Does all of this belong here?
> - Should Percentiles be renamed to Quantiles, given that you actually just specify a
0.0-1.0 range? Quantiles is more accurate, but people are more likely to search for Percentiles.
> - Would the DoFns.detach(...) functionality be better implemented as a DetachingReduceFn
base class rather than a wrap-and-delegate?

This message was sent by Atlassian JIRA

View raw message