crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Wills (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CRUNCH-484) Add library features from spotify/crunch-lib into crunch-core
Date Sat, 03 Jan 2015 21:40:34 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Josh Wills updated CRUNCH-484:
------------------------------
    Attachment: CRUNCH-484b.patch

Same, but with the rename to Quantiles-- did you want to tweak the comments for the methods
as well?

> Add library features from spotify/crunch-lib into crunch-core
> -------------------------------------------------------------
>
>                 Key: CRUNCH-484
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-484
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: David Whiting
>            Assignee: Josh Wills
>         Attachments: 0001-CRUNCH-484-Add-library-features-from-spotify-crunch-.patch,
CRUNCH-484.patch, CRUNCH-484b.patch
>
>
> As suggested by Josh, I've patched the more generally-applicable stuff from https://github.com/spotify/crunch-lib
into org.apache.crunch.lib
> Open questions:
> - Does all of this belong here?
> - Should Percentiles be renamed to Quantiles, given that you actually just specify a
0.0-1.0 range? Quantiles is more accurate, but people are more likely to search for Percentiles.
> - Would the DoFns.detach(...) functionality be better implemented as a DetachingReduceFn
base class rather than a wrap-and-delegate?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message