crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allan Shoup (JIRA)" <>
Subject [jira] [Updated] (CRUNCH-446) Add null checks for DoFn fields
Date Tue, 12 Aug 2014 18:35:12 GMT


Allan Shoup updated CRUNCH-446:

    Attachment: CRUNCH-446.3.patch

Added patch 3. This patch goes back to the less-invasive original patch with two additional
fixes cited in [my previous comment|].

> Add null checks for DoFn fields
> -------------------------------
>                 Key: CRUNCH-446
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Allan Shoup
>            Priority: Minor
>         Attachments: CRUNCH-446.2.patch, CRUNCH-446.3.patch, CRUNCH-446.patch
> DoFn.getConfiguration() gracefully handles the fields being null, but most other methods
do not. Adding null checks around all field access within DoFn would make it easier for consumers
to write tests for their own function classes because they would not be required to set the
context, for instance.

This message was sent by Atlassian JIRA

View raw message