crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micah Whitacre (JIRA)" <>
Subject [jira] [Commented] (CRUNCH-405) Explore adding support for idempotent MRPipeline.plan()
Date Wed, 06 Aug 2014 02:20:13 GMT


Micah Whitacre commented on CRUNCH-405:

Err sorry I got my keywords mixed up, "currentExecutor" should be marked volatile not transient.
(can't explain what wires got crossed to make that mistake)

Would you make the release method synchronized?  Otherwise marking "currentExecutor" as volatile
should make the state change visible sooner but wouldn't eliminate all timing issues if the
callable was slow to run.  What if the MRPipeline.plan(...) only threw that exception if the
MRExecutor.hasStarted() == false?  Would we want to block at that point or would that might
undermine any value with runAsync()?

> Explore adding support for idempotent MRPipeline.plan()
> -------------------------------------------------------
>                 Key: CRUNCH-405
>                 URL:
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Micah Whitacre
>            Assignee: Micah Whitacre
>         Attachments: CRUNCH-405.patch, CRUNCH-405_v1.patch
> Talking through a use case with a consumer, they were interested in having the ability
to run the MRPipeline.plan() method one to many times prior to ever calling the
methods.  The reason for this was they were looking at pulling information off the MRExecutor
to tweak settings inside of their DoFns.
> Currently the MRPipeline implementation however does not have an idempotent plan() method
as it alters the state of internal values therefore affecting the full run once done() is
> It would be nice if we added an idempotent plan() method that could be gather this information
or perhaps a reset option.  

This message was sent by Atlassian JIRA

View raw message