Return-Path: X-Original-To: apmail-crunch-dev-archive@www.apache.org Delivered-To: apmail-crunch-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 434FA11B1C for ; Wed, 9 Jul 2014 02:13:05 +0000 (UTC) Received: (qmail 21461 invoked by uid 500); 9 Jul 2014 02:13:05 -0000 Delivered-To: apmail-crunch-dev-archive@crunch.apache.org Received: (qmail 21419 invoked by uid 500); 9 Jul 2014 02:13:05 -0000 Mailing-List: contact dev-help@crunch.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@crunch.apache.org Delivered-To: mailing list dev@crunch.apache.org Received: (qmail 21397 invoked by uid 500); 9 Jul 2014 02:13:05 -0000 Delivered-To: apmail-incubator-crunch-dev@incubator.apache.org Received: (qmail 21394 invoked by uid 99); 9 Jul 2014 02:13:05 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Jul 2014 02:13:05 +0000 Date: Wed, 9 Jul 2014 02:13:05 +0000 (UTC) From: "Micah Whitacre (JIRA)" To: crunch-dev@incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CRUNCH-414) The CSV file source needs to be a little more robust when handling multi-line CSV files MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CRUNCH-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14055767#comment-14055767 ] Micah Whitacre commented on CRUNCH-414: --------------------------------------- Made a few comments on the pull request. > The CSV file source needs to be a little more robust when handling multi-line CSV files > --------------------------------------------------------------------------------------- > > Key: CRUNCH-414 > URL: https://issues.apache.org/jira/browse/CRUNCH-414 > Project: Crunch > Issue Type: Improvement > Components: Core > Affects Versions: 0.8.3 > Reporter: mac champion > Assignee: mac champion > Priority: Minor > Labels: csv, csvparser > Fix For: 0.8.4 > > Attachments: 0001-CRUNCH-414-CSVLineReader-Threshold-Logic.patch > > Original Estimate: 336h > Remaining Estimate: 336h > > Brandon Inman recently reported an undesriable behavior in the CSV file source group of files. Currently, the CSVLineReader, if reading a malformed CSV file, can enter a state where it is perpetually waiting for an end-quote character. As he put it, "Malformed files are malformed files and should probably fail in some regard, but a hang is obviously undesirable." > Essentially, the CSVLineReader needs to be tweaked in such a way that an informative exception is thrown after some threshold is reached, instead of basically just hanging. -- This message was sent by Atlassian JIRA (v6.2#6252)