crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allan Shoup (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-446) Add null checks for DoFn fields
Date Thu, 17 Jul 2014 20:51:04 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065521#comment-14065521
] 

Allan Shoup commented on CRUNCH-446:
------------------------------------

It looks like there is a lot of code that assumes the result of getConfiguration will not
be null, so there will likely need to be code changes either way.

> Add null checks for DoFn fields
> -------------------------------
>
>                 Key: CRUNCH-446
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-446
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Allan Shoup
>            Priority: Minor
>         Attachments: CRUNCH-446.2.patch, CRUNCH-446.patch
>
>
> DoFn.getConfiguration() gracefully handles the fields being null, but most other methods
do not. Adding null checks around all field access within DoFn would make it easier for consumers
to write tests for their own function classes because they would not be required to set the
context, for instance.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message