crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micah Whitacre (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-357) Allow AvroMode overrides to be less global
Date Fri, 18 Jul 2014 15:18:05 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066433#comment-14066433
] 

Micah Whitacre commented on CRUNCH-357:
---------------------------------------

Unfortunately with this change where we got rid of any global manipulation of the AvroMode
it was necessary.  The only other option would be for that method to have been a no-op and
that silent failure would have caused a different set of problems.

> Allow AvroMode overrides to be less global
> ------------------------------------------
>
>                 Key: CRUNCH-357
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-357
>             Project: Crunch
>          Issue Type: Improvement
>          Components: Core, IO
>            Reporter: Micah Whitacre
>            Assignee: Micah Whitacre
>             Fix For: 0.10.0, 0.8.3
>
>         Attachments: CRUNCH-357.patch, CRUNCH-357_immutable.patch, CRUNCH-357_immutable_with_doctests.patch
>
>
> Currently consumers wanting to specify a custom reader must globally override the ReaderFactory
for a specific mode.  This means that if one AvroFileSource changes the factory it could affect
all other sources in the pipeline without anyone knowing it.
> One thought was what if a consumer could get a "local" AvroMode instance, configure it
to their needs and then specify that mode to the AvroFileSource to configure that source without
changing any global state.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message