crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Micah Whitacre (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CRUNCH-429) The CSVFileSource does not always function properly
Date Thu, 26 Jun 2014 21:17:24 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Micah Whitacre updated CRUNCH-429:
----------------------------------

    Attachment: CRUNCH-429_a.patch

Signed off on Mac's patch but made a few smaller changes:

*Handled potential NPE:
https://github.com/apache/crunch/blob/8027f706ae47b613c6f0e96e0ee9f7ef21d1d6ed/crunch-core/src/main/java/org/apache/crunch/io/text/csv/CSVInputFormat.java#L96
* Fixed "configuraiton" spelling error in original patch.
* Moved FileSystem retrieval outside of for loop:
https://github.com/apache/crunch/blob/8027f706ae47b613c6f0e96e0ee9f7ef21d1d6ed/crunch-core/src/main/java/org/apache/crunch/io/text/csv/CSVInputFormat.java#L90
* Removed broken Javadoc



> The CSVFileSource does not always function properly
> ---------------------------------------------------
>
>                 Key: CRUNCH-429
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-429
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.3
>            Reporter: mac champion
>            Assignee: Josh Wills
>            Priority: Minor
>              Labels: csv, csvparser
>         Attachments: 0001-CRUNCH-429-Fix-CSVInputFormat.patch, CRUNCH-429_a.patch
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> The "configure" method of CSVInputFormat does not have any effect on its configuration
and is never called. Instead, the class needs to implement Configurable and set its configuration
options in an overriden setConf method.  



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message