crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Allan Shoup (JIRA)" <>
Subject [jira] [Commented] (CRUNCH-418) Auto-logging Plan
Date Wed, 18 Jun 2014 00:09:03 GMT


Allan Shoup commented on CRUNCH-418:

Gabriel, I'm attaching a slightly tweaked version of your patch. Here are the differences:
* Added a _thrownException_ variable to prevent an exception caused on closing the stream
to potentially hide the more important exception that occurs when using the stream (Java 7
would be nice here)
* I just chopped the pipeline name off at 150 characters as I figure this will be easier to
document than 200 minus what was left after the timestamp, etc.
* I switched the _filenamePrefix_ to keep the first part of the pipeline name instead of the
last part as that seemed like the more important section - I wasn't sure if it was an intentional
decision or not to keep the last part.
* I went ahead and propagated an exception when the _URISyntaxException_ was caught. I wasn't
sure if there was a reason this behaved differently than _IOException_.

> Auto-logging Plan
> -----------------
>                 Key: CRUNCH-418
>                 URL:
>             Project: Crunch
>          Issue Type: Wish
>            Reporter: Allan Shoup
>            Assignee: Gabriel Reid
>            Priority: Minor
>         Attachments: CRUNCH-418.2.patch, CRUNCH-418.3.patch, CRUNCH-418.patch
> It would be handy if Crunch was capable of logging out the plan DOT diagram automatically
whenever the pipeline was run.
> By default I would log the plan at a level below INFO - probably at DEBUG.
> Additionally, configuration could be provided to specify the level that the plan should
be logged at (for example if you always wanted it logged at INFO level, or if you wanted to
disable logging the plan altogether).

This message was sent by Atlassian JIRA

View raw message