crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <>
Subject [jira] [Commented] (CRUNCH-418) Auto-logging Plan
Date Tue, 17 Jun 2014 15:06:05 GMT


Gabriel Reid commented on CRUNCH-418:

Thanks for taking a look guys. 

{quote}Do we need to worry about file name length restrictions?{quote}
I think it's pretty somewhat unlikely that filename length restrictions would be a problem
here, but definitely not impossible. I'll update the patch to truncate the job name when creating
the dot file just to be sure.

{quote}Also, in writePlanDotFile, it looks like an exception during the file write will leave
the output stream open.{quote}
Thanks for catching that -- and yes, that IO code should definitely have a finally block in
there. I'll fix that too.

{quote}Is there a good place to document the file name format (without having to rely on the
code being the specification) so tool authors can automatically pick this file up.{quote}
Yes, the [User Guide|] is the place for this. I was
planning on adding a blurb on this change to the User Guide, but if you're up for doing that
it would be great! If you want to just post the text that you would add on this issue I'll
add it into the user guide. It's also possible to generate a diff via the CMS that is used
for the user guide -- the documentation for the CMS is here:

> Auto-logging Plan
> -----------------
>                 Key: CRUNCH-418
>                 URL:
>             Project: Crunch
>          Issue Type: Wish
>            Reporter: Allan Shoup
>            Assignee: Gabriel Reid
>            Priority: Minor
>         Attachments: CRUNCH-418.patch
> It would be handy if Crunch was capable of logging out the plan DOT diagram automatically
whenever the pipeline was run.
> By default I would log the plan at a level below INFO - probably at DEBUG.
> Additionally, configuration could be provided to specify the level that the plan should
be logged at (for example if you always wanted it logged at INFO level, or if you wanted to
disable logging the plan altogether).

This message was sent by Atlassian JIRA

View raw message