crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Wills <jwi...@cloudera.com>
Subject Re: Binary Passivity
Date Fri, 27 Jun 2014 00:01:44 GMT
Yes, it would. Will file a JIRA and fix it.


On Thu, Jun 26, 2014 at 10:30 AM, Allan Shoup <allan.shoup@gmail.com> wrote:

> Wouldn't it be better to add them both instead of removing the AvroType
> version?
>
>
> On Thu, Jun 26, 2014 at 11:18 AM, Josh Wills <josh.wills@gmail.com> wrote:
>
> > That one was intentional, at least from my perspective.
> > On Jun 26, 2014 10:25 PM, "Champion,Mac" <Mac.Champion@cerner.com>
> wrote:
> >
> > > I found another incompatibility/non-passive change while trying to
> > upgrade
> > > a project from 0.8.2 to 0.8.3, From.avroFile(Path,AvroType) seems to
> have
> > > disappeared.
> > >
> > > It exists in Crunch 0.8.2
> > >
> >
> https://github.com/apache/crunch/blob/apache-crunch-0.8.2/crunch-core/src/m
> > > ain/java/org/apache/crunch/io/From.java#L167
> > >
> > > But is nowhere to be found in 0.8.3
> > >
> >
> https://github.com/apache/crunch/blob/apache-crunch-0.8.3/crunch-core/src/m
> > > ain/java/org/apache/crunch/io/From.java#L227
> > >
> > > The method seems to have been replaced by a ³avroFile(Path,PType)"
> > method.
> > > Was this intentional? Should I log a defect JIRA for it to be added
> back?
> > >
> > >
> > >
> > > On 6/23/14, 2:47 PM, "Allan Shoup" <allan.shoup@gmail.com> wrote:
> > >
> > > >Logged https://issues.apache.org/jira/browse/CRUNCH-426
> > > >
> > > >
> > > >On Mon, Jun 23, 2014 at 2:21 PM, Micah Whitacre <mkwhit@gmail.com>
> > wrote:
> > > >
> > > >> I'm not sure we explicitly strive for it but that change is my
> fault.
> > > >>You
> > > >> can log a bug and I'll try to see what I can do to fix it.
> > > >>
> > > >>
> > > >> On Mon, Jun 23, 2014 at 10:36 AM, Allan Shoup <
> allan.shoup@gmail.com>
> > > >> wrote:
> > > >>
> > > >> > It looks like crunch-hbase:0.8.3 is not binary-compatible with
> 0.8.2
> > > >>(the
> > > >> > HBaseSourceTarget changed the second parameter from a Scan to
a
> > > >>Scan[]).
> > > >> Is
> > > >> > binary passivity a goal? If so, I can file a bug for this.
> > > >> >
> > > >>
> > >
> > > CONFIDENTIALITY NOTICE This message and any included attachments are
> from
> > > Cerner Corporation and are intended only for the addressee. The
> > information
> > > contained in this message is confidential and may constitute inside or
> > > non-public information under international, federal, or state
> securities
> > > laws. Unauthorized forwarding, printing, copying, distribution, or use
> of
> > > such information is strictly prohibited and may be unlawful. If you are
> > not
> > > the addressee, please promptly delete this message and notify the
> sender
> > of
> > > the delivery error by e-mail or you may call Cerner's corporate offices
> > in
> > > Kansas City, Missouri, U.S.A at (+1) (816)221-1024.
> > >
> >
>



-- 
Director of Data Science
Cloudera <http://www.cloudera.com>
Twitter: @josh_wills <http://twitter.com/josh_wills>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message