crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gabriel Reid (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CRUNCH-406) Have the Avro IO methods in From/To take PTypes instead of AvroTypes
Date Fri, 30 May 2014 20:11:02 GMT

    [ https://issues.apache.org/jira/browse/CRUNCH-406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14014168#comment-14014168
] 

Gabriel Reid commented on CRUNCH-406:
-------------------------------------

+1 for the patch. I've definitely been annoyed with it in the past, but never gone far enough
to actually do something about it.



> Have the Avro IO methods in From/To take PTypes instead of AvroTypes
> --------------------------------------------------------------------
>
>                 Key: CRUNCH-406
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-406
>             Project: Crunch
>          Issue Type: Improvement
>            Reporter: Josh Wills
>         Attachments: CRUNCH-406.patch
>
>
> I'm finding it somewhat annoying to have to cast PTypes from different contexts (like
from a PCollection.getPType or from a derived type) back to AvroType whenever I want to use
From/At.avroFile methods. I think we can safely move the casting into the From/At methods
and assume that someone who is using Avro will only ever be using it with the AvroTypeFamily.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message