crunch-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Wills (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CRUNCH-401) Make it possible to override AvroMode.REFLECTs ReaderWriterFactory
Date Fri, 30 May 2014 03:34:01 GMT

     [ https://issues.apache.org/jira/browse/CRUNCH-401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Josh Wills updated CRUNCH-401:
------------------------------

    Attachment: CRUNCH-401b.patch

Some more work on this to remove other non-AvroMode based references to ReflectData that were
sprinkled in the code.

[~mkwhitacre] on the crunch.reflectdatafactory param, I'm still not sure on what the best
way to reference the deprecated param value in the Avros class; is it okay to leave it deprecated
there, but create a copy of it inside of AvroMode that is un-deprecated? Or is that just more
confusing?

> Make it possible to override AvroMode.REFLECTs ReaderWriterFactory
> ------------------------------------------------------------------
>
>                 Key: CRUNCH-401
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-401
>             Project: Crunch
>          Issue Type: Bug
>          Components: Core
>            Reporter: Josh Wills
>            Assignee: Josh Wills
>         Attachments: CRUNCH-401.patch, CRUNCH-401b.patch
>
>
> After struggling with some Scrunch issues w/respect to Avro reflection, I discovered
that it wasn't possible for me to override the Java ReflectDataFactory that is associated
with AvroMode.REFLECT like I can for AvroMode.SPECIFIC and AvroMode.GENERIC.
> I put together a patch that enables us to overwrite the Reader/Writer behavior associated
with AvroMode.REFLECT globally, and demonstrated how to use this behavior to fix a Scrunch
bug where Scala's byte array class wasn't getting properly serialized on reflection in Scrunch.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message